lvm: Add support for running vgcfgbackup/restore #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbzatek
reviewed
May 30, 2025
Member
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
Just some minor docs clarifications, otherwise the code looks sane to me.
| /** | ||
| * bd_lvm_vgcfgbackup: | ||
| * @vg_name: name of the VG to backup | ||
| * @backup_file: (nullable): file to save the backup to or %NULL for using the default backup file |
Member
There was a problem hiding this comment.
I still get an impression that this is about backing up the whole VG data. I think it should be noted this is about configuration of the VG.
Member
Author
There was a problem hiding this comment.
Ok, I've changed both the docstrings to emphasize the backup/restore is for configuration only. I've also added note from the vgcfgbackup which mentions this doesn't back up the LV data.
src/lib/plugin_apis/lvm.api
Outdated
| * (just passed to LVM as is) | ||
| * @error: (out) (optional): place to store error (if any) | ||
| * | ||
| * Returns: Whether the backup was successfully created or not. |
Member
There was a problem hiding this comment.
Perhaps add a sentence from the vgcfgrestore(8) manpage?
Restore volume group configuration
vgcfgrestore restores the metadata of a VG from a text back up file produced by vgcfgbackup.
vojtechtrefny
force-pushed
the
master_vg-backup-restore
branch
from
32fc59d to
6f58d70
Compare
tbzatek
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #565